Catch exception and return false in cases where std::regex_match throws. #10861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Vicente <avd@google.com>
penguingao
pushed a commit
to penguingao/envoy
that referenced
this pull request
Apr 22, 2020
…ws. (envoyproxy#10861) Signed-off-by: Antonio Vicente <avd@google.com> Signed-off-by: pengg <pengg@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Catch exception and return false in cases where std::regex_match throws. std::regex can throw during match. Catch the exception to avoid a potential for crashes in the data plane. The impact of this change is low since std::regex in config are deprecated in favor of RE2.
Risk Level: low, std::regex in config are deprecated.
Testing: unit
Docs Changes: n/a
Release Notes: n/a