Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LuaJIT patch - remove MAP_32BIT #10867

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

JohnMurray
Copy link
Contributor

Description: Update LuaJIT patch-file to disable use of MAP_32BIT flag in mmap calls.
Risk Level: Low
Testing: Manual
Docs Changes: n/a
Release Notes: n/a
Fixes #10865

Remove flag MAP_32BIT to allow for >1gb mmap's that occur at higher
concurrency levels.

Signed-off-by: John Murray <me@johnmurray.io>
@JohnMurray JohnMurray force-pushed the luajit-remove-map-32bit branch from a849e20 to 86add0e Compare April 20, 2020 23:08
@mattklein123 mattklein123 self-assigned this Apr 20, 2020
@JohnMurray
Copy link
Contributor Author

JohnMurray commented Apr 20, 2020

Seeing a network related failure (downloading deps).

@JohnMurray
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

🐴 hold your horses - no failures detected, yet.

🐱

Caused by: a #10867 (comment) was created by @JohnMurray.

see: more, trace.

@mattklein123
Copy link
Member

/azp run envoy-presubmit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit 68a770f into envoyproxy:master Apr 21, 2020
@JohnMurray JohnMurray deleted the luajit-remove-map-32bit branch April 22, 2020 02:12
penguingao pushed a commit to penguingao/envoy that referenced this pull request Apr 22, 2020
Remove flag MAP_32BIT to allow for >1gb mmap's that occur at higher
concurrency levels.

Signed-off-by: John Murray <me@johnmurray.io>
Signed-off-by: pengg <pengg@google.com>
lambdai added a commit to istio/envoy that referenced this pull request May 21, 2021
Lua: Change the TLS callback function type of ThreadLocalState to Upd… (envoyproxy#11944)
Update LuaJIT patch - remove MAP_32BIT (envoyproxy#10867)

Signed-off-by: wbpcode <comems@msn.com>
Signed-off-by: John Murray <me@johnmurray.io>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Change-Id: I62739dc1c3250fcff755d0a6208ec4f78cda695b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SegFault - LuaJIT unable to initialize state due to mmap exhaustion
2 participants