status: Fix ASAN error in Status payload handling #10906
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
The absl::Status::GetPayload was returning a copy of the payload and was generating ASAN errors due to lifetime of the copy. Modify payload accessor to use absl::Status::ForEachPayload which allows getting a reference to the payload owned by the Status object. This solves lifetime issues and avoids needless copying.
Also update absl to pull in Cord::TryFlat() method.
Risk Level: Low
Testing: Unit Tests
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Yan Avlasov yavlasov@google.com