eds: optionalize counting of unknown fields #10982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Phil Genera <pgenera@google.com> Signed-off-by: Joshua Marantz <jmarantz@google.com>
…ch requested. Signed-off-by: Phil Genera <pgenera@google.com>
htuch
suggested changes
Apr 28, 2020
Signed-off-by: Phil Genera <pgenera@google.com>
Signed-off-by: Phil Genera <pgenera@google.com>
Signed-off-by: Phil Genera <pgenera@google.com>
Signed-off-by: Phil Genera <pgenera@google.com>
htuch
suggested changes
May 6, 2020
|
|
||
| bool skipValidation() override { return skip_validation_; } | ||
|
|
||
| void setSkipValidation(bool s) { skip_validation_ = s; } |
There was a problem hiding this comment.
For mocks, we generally don't have setters and expose the fiels, but this doesn't hurt I guess.
| return fmt::format( | ||
| "{}_{}", | ||
| "{}_{}_{}", |
There was a problem hiding this comment.
How long does this test take to run now? Generally wary of uncontrolled combinatorial explosision. If it's not too long it's fine, but prefer to have only a meaningful subset of tests validated with this setting.
There was a problem hiding this comment.
8.5s (locally on my corp machine), compared to 5s without the change. It's in the middle of the pack of //test/integration:all, with the longest ones in the 60s range.
It's around 20s with RBE, but still pretty average for the integration tests.
Signed-off-by: Phil Genera <pgenera@google.com>
htuch
reviewed
May 8, 2020
htuch
suggested changes
May 8, 2020
Signed-off-by: Phil Genera <pgenera@google.com>
htuch
reviewed
May 11, 2020
Signed-off-by: Phil Genera <pgenera@google.com>
Signed-off-by: Phil Genera <pgenera@google.com>
Signed-off-by: Phil Genera <pgenera@google.com>
Signed-off-by: Phil Genera <pgenera@google.com>
|
The remaining clang-tidy complaint is pre-existing, I believe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: In order to speed up eds, don't necessarily visit every proto field to count its validity as WarningValidationVisitor does. This yields a ~30% speed improvement in processing very large updates in EDS.
Risk Level: medium, new feature behind a command line flag.
Testing: Unit and bechmark tests.
Docs Changes: These are probably wrong, thus the draft-ness.
Release Notes: EDS can now ignore unknown dynamic fields, for a ~30% improvement in update processing time. Behind --ignore-unknown-dynamic-fields