Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: various build fixes for 1.13.x #11054

Merged
merged 9 commits into from
May 8, 2020
Merged

backport: various build fixes for 1.13.x #11054

merged 9 commits into from
May 8, 2020

Conversation

lizan
Copy link
Member

@lizan lizan commented May 5, 2020 •
edited
Loading

Commit Message:
Cherry-picks:
3804528 and removed Windows from CI.
dc197e5
5306563
bc2d1d3
660891e
a85f8ec

Risk Level: Low
Testing: CI
Docs Changes:
Release Notes:
Part of #10741

lizan and others added 8 commits May 5, 2020 00:28
@lizan
release: kick-off 1.13.2-dev
8f8d1fc 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan
ci: refactor azp into one pipeline (#10564)
174ce2a 
Description:
Merge all platforms into one pipelines to
- guard mac and windows CI by format check
- guard additional checks (asan, tsan, tidy..) by release to reduce CI pressure.
- not guard docker image build by sanitizers.
- refactor out bazel steps to another yaml file

Risk Level: Low (CI only)
Testing: CI
Docs Changes:
Release Notes:

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@mattklein123 @lizan
build: refine docker image CI process (#10729)
2193d3d 
Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan
ci: remove tools from agent for disk (#10775)
e10788f 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan
ci: update before purge in cleanup (#10938)
d5b54e5 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@sunjayBhatia @lizan
ci: force install/link bazelisk package in macos dependency setup (#1…
dffa478 
…0357)

Latest mac os images have bazel pre-installed so force install bazelisk and link with overwrite to allow install to succeed

Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A

Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan
ci: save a few GB disk space (#10669)
72bc5df 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan
disable clang-tidy
121ac3d 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan lizan marked this pull request as ready for review May 6, 2020 21:08
@lizan lizan requested a review from PiotrSikora May 6, 2020 21:08
@PiotrSikora
Copy link
Contributor

I re-kicked the coverage build, but it failed because of this:

[ RUN      ] QuicMemSliceStorageImplTest.MultipleIovInMultipleSlice
bazel-out/k8-fastbuild/bin/external/com_googlesource_quiche/quiche/quic/platform/api/quic_mem_slice_storage_test.cc:56: Failure
Expected equality of these values:
  "aaaa"
    Which is: 0x25b7a2
  span.GetData(0)
    Which is: "aaaabbbb"
Stack trace:
  0xe87a544: quic::test::(anonymous namespace)::QuicMemSliceStorageImplTest_MultipleIovInMultipleSlice_Test::TestBody()
  0x101e6ef6: testing::internal::HandleSehExceptionsInMethodIfSupported<>()
  0x101d3441: testing::internal::HandleExceptionsInMethodIfSupported<>()
  0x101bdef2: testing::Test::Run()
  0x101be9f8: testing::TestInfo::Run()
... Google Test internal frames ...

unknown file: Failure
C++ exception with description "std::bad_alloc" thrown in the test body.
[  FAILED  ] QuicMemSliceStorageImplTest.MultipleIovInMultipleSlice (889 ms)

@lizan
Copy link
Member Author

lizan commented May 8, 2020

@PiotrSikora See #10287, those targets are only included in coverage so I think we can just disable them in 1.13?

@PiotrSikora
Copy link
Contributor

@PiotrSikora See #10287, those targets are only included in coverage so I think we can just disable them in 1.13?

Sounds good! Thanks.

@lizan lizan merged commit ccf2487 into release/v1.13 May 8, 2020
@lizan lizan deleted the 1.13_build branch May 8, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiotrSikora PiotrSikora PiotrSikora approved these changes

Assignees

@PiotrSikora PiotrSikora

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lizan @PiotrSikora @mattklein123 @sunjayBhatia