udpa: UDPA URI encoding/decoding utils. #11678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix an off-by-one bug in PercentEncoding::encode. * Generalize from '%' to arbitrary visible reserved chars. This change was motivated by a larger patch that provides encoding/decoding of udpa:// URIs, as part of envoyproxy#11264. Risk level: Low Testing: Additional unit tests. Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
These map between the structured udpa::core::v1::ResourceName message and flat udpa:// URI representations of resource names. Risk level: Low Testing: Unit tests added. Part of envoyproxy#11264. Signed-off-by: Harvey Tuch <htuch@google.com>
|
This relies on #11677 and cncf/udpa#29 merging first. |
markdroth
reviewed
Jun 22, 2020
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
|
@mattklein123 I think this is ready for review. |
Signed-off-by: Harvey Tuch <htuch@google.com>
mattklein123
approved these changes
Jun 25, 2020
songhu
pushed a commit
to songhu/envoy
that referenced
this pull request
Jun 25, 2020
These map between the structured udpa::core::v1::ResourceName message and flat udpa:// URI representations of resource names. Risk level: Low Testing: Unit tests added. Part of envoyproxy#11264. Signed-off-by: Harvey Tuch <htuch@google.com>
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jul 24, 2020
These map between the structured udpa::core::v1::ResourceName message and flat udpa:// URI representations of resource names. Risk level: Low Testing: Unit tests added. Part of envoyproxy#11264. Signed-off-by: Harvey Tuch <htuch@google.com> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These map between the structured udpa::core::v1::ResourceName message and flat udpa:// URI
representations of resource names.
Risk level: Low
Testing: Unit tests added.
Part of #11264.
Signed-off-by: Harvey Tuch htuch@google.com