Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: cutting 1.15 #11898

Merged
merged 4 commits into from
Jul 7, 2020
Merged

release: cutting 1.15 #11898

merged 4 commits into from
Jul 7, 2020

Conversation

alyssawilk
Copy link
Contributor

@alyssawilk alyssawilk commented Jul 6, 2020

Risk Level: n/a
Testing: n/a
Docs Changes: yes
Release Notes: exactly

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@alyssawilk
Copy link
Contributor Author

@envoyproxy/maintainers

jmarantz
jmarantz previously approved these changes Jul 6, 2020
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@alyssawilk alyssawilk changed the title docs: cleaning up release notes release: cutting 1.15 Jul 6, 2020
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@ggreenway ggreenway self-assigned this Jul 6, 2020
@alyssawilk
Copy link
Contributor Author

cc @sunjayBhatia @wrowe for windows failures

@sunjayBhatia
Copy link
Member

cc @sunjayBhatia @wrowe for windows failures

//test/extensions/filters/http/router:auto_sni_integration_test is one of the tests we recently untagged as failing on Windows, but it and other integration tests seems to intermittently fail in CI the same way:

[2020-07-06 16:45:50.317][4396][critical][assert] [test/integration/integration.cc:489] assert failure: 0. Details: Timed out waiting for listeners.

We haven't observed the same patterns locally as far as I remember, so we may need to revisit this test setup, default 10s timeout, or otherwise

@alyssawilk
Copy link
Contributor Author

I think either fix would be fine as a short term workaround, but needing more than 5s to successfully listen probably indicates some other bug given the builds don't look extremely slow or otherwise machine contended.
You could try a "DO NOT SUBMIT" test run with -l trace on to see if that gets you any more info? See #11861 on LIzan turning up logs for coverage. Feel free to tag me if you need help diagnosing the fascinating corner case failures of the integration tests :-P

@sunjayBhatia
Copy link
Member

I think either fix would be fine as a short term workaround, but needing more than 5s to successfully listen probably indicates some other bug given the builds don't look extremely slow or otherwise machine contended.
You could try a "DO NOT SUBMIT" test run with -l trace on to see if that gets you any more info? See #11861 on LIzan turning up logs for coverage. Feel free to tag me if you need help diagnosing the fascinating corner case failures of the integration tests :-P

Just submitted #11904, we should hopefully get some more data soon

@@ -1,5 +1,5 @@
1.15.0 (Pending)
================
1.15.0 (July 6, 2020)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to git mv current.rst v1.15.0.rst, and then add an entry in version_history.rst

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

governance.md says to do that after cutting the release. let me dig through logs and see what we did last time

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, we haven't done one since the new docs set up.
I'm cool either way. Want me to move the file and update the instructions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my mistake. Follow the governance.

@alyssawilk alyssawilk merged commit 50ef094 into envoyproxy:master Jul 7, 2020
scheler pushed a commit to scheler/envoy that referenced this pull request Aug 4, 2020
Risk Level: n/a
Testing: n/a
Docs Changes: yes
Release Notes: exactly
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: scheler <santosh.cheler@appdynamics.com>
@alyssawilk alyssawilk deleted the relnotes branch October 26, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants