tidy: allow run clang_tidy with file #12472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
mattklein123
approved these changes
Aug 4, 2020
jmarantz
reviewed
Aug 4, 2020
| @@ -284,7 +284,7 @@ elif [[ "$CI_TARGET" == "bazel.coverage" || "$CI_TARGET" == "bazel.fuzz_coverage | |||
| exit 0 | |||
| elif [[ "$CI_TARGET" == "bazel.clang_tidy" ]]; then | |||
| setup_clang_toolchain | |||
| NUM_CPUS=$NUM_CPUS ci/run_clang_tidy.sh | |||
| NUM_CPUS=$NUM_CPUS ci/run_clang_tidy.sh $* | |||
There was a problem hiding this comment.
oops sorry I missed this, #12476
lizan
added a commit
to lizan/envoy
that referenced
this pull request
Aug 4, 2020
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Aug 7, 2020
Refactor `ci/clang_tidy.sh` and `ci/do_ci.sh` to allow run clang-tidy for specified source file. Make running clang_tidy with build container or within devcontainer easier. Risk Level: Low Testing: Local, CI Docs Changes: Yes Release Notes: N/A Signed-off-by: Lizan Zhou <lizan@tetrate.io>
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Aug 7, 2020
Refactor `ci/clang_tidy.sh` and `ci/do_ci.sh` to allow run clang-tidy for specified source file. Make running clang_tidy with build container or within devcontainer easier. Risk Level: Low Testing: Local, CI Docs Changes: Yes Release Notes: N/A Signed-off-by: Lizan Zhou <lizan@tetrate.io> Signed-off-by: chaoqinli <chaoqinli@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
ci/clang_tidy.shandci/do_ci.shto allow run clang-tidy for specified source file. Make running clang_tidy with build container or within devcontainer easier.Risk Level: Low
Testing: Local, CI
Docs Changes: Yes
Release Notes: N/A
Signed-off-by: Lizan Zhou lizan@tetrate.io