Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: build #12604

Closed
wants to merge 1 commit into from
Closed

Dependencies: build #12604

wants to merge 1 commit into from

Conversation

moderation
Copy link
Contributor

Signed-off-by: moderation michael@sooper.org

  • Finalize move from jbeder_yaml to new repo
  • Update language from Skylark to Starlark
  • Comment sorting of bazel/repository_locations.bzl
  • build dependency updates

Risk Level: Low
Testing: bazel --nohome_rc build @envoy_api//envoy/..., bazel --nohome_rc test //test/...
Docs Changes: none required
Release Notes: none required

Signed-off-by: moderation <michael@sooper.org>
http_archive(
name = "com_github_jbeder_yaml_cpp",
name = "com_github_greenhouse_org_yaml_cpp",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't rename this, this has to match what in https://github.com/greenhouse-org/yaml-cpp/blob/master/WORKSPACE#L1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants