Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clang-cl RBE toolchain for Windows #12776

Merged
merged 1 commit into from
Aug 22, 2020
Merged

Add clang-cl RBE toolchain for Windows #12776

merged 1 commit into from
Aug 22, 2020

Conversation

sunjayBhatia
Copy link
Member

Commit Message:
Add clang-cl RBE toolchain for Windows

Bumps envoy-build-tools to latest as of 2020/08/21 and envoy build
container image

clang-cl toolchain not yet enabled in CI as not all dependencies
compile, will submit a draft PR demonstrating compilation failures
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A

Bumps envoy-build-tools to latest as of 2020/08/21 and envoy build
container image

clang-cl toolchain not yet enabled in CI as not all dependencies
compile, will submit a draft PR demonstrating compilation failures

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Co-authored-by: William A Rowe Jr <wrowe@vmware.com>
@sunjayBhatia
Copy link
Member Author

cc @envoyproxy/windows-dev

@sunjayBhatia
Copy link
Member Author

cc @htuch, making some progress on clang-cl on Windows

@sunjayBhatia
Copy link
Member Author

Related issue: #11974

@sunjayBhatia
Copy link
Member Author

We are testing this change locally so far (seems to be going well) and once we iron out any issues, we will open a PR to enable clang-cl builds in CI for Windows

@lizan lizan merged commit 8370742 into envoyproxy:master Aug 22, 2020
@wrowe wrowe deleted the windows-add-clang-cl-toolchain branch August 24, 2020 14:17
lavignes added a commit to lavignes/envoy that referenced this pull request Aug 24, 2020
* envoy/master: (90 commits)
  cleanup: use structured binding (envoyproxy#12791)
  docs: fix header name for retries in gRPC services (envoyproxy#12790)
  docs: clarify meaning of HeaderValueOption.append (envoyproxy#12792)
  doc: clarify handling of duplicate xDS resource names (envoyproxy#12756)
  Dependencies: build updates. (envoyproxy#12786)
  Ratelimit: Add optional descriptor key to generic_key action (envoyproxy#12734)
  test: refactor header inclusion to speed up building (for test/mocks/upstream:upstream_mocks)  (envoyproxy#12407)
  docs: Fix omitted word (envoyproxy#12782)
  ci: avoid uploading dwp as separate artifact (envoyproxy#12777)
  doc: Fix small typos (envoyproxy#12769)
  fix cache factory category (envoyproxy#12765)
  docs: fix typo v1.15.0.rst (envoyproxy#12680)
  Add clang-cl RBE toolchain for Windows (envoyproxy#12776)
  fuzz: add router fuzz proto (envoyproxy#12727)
  header: New HeaderMatcher and StringMatcher type - Contains (envoyproxy#12623)
  tcp_proxy: use dynamicMetadata() from StreamInfo for load balancing (envoyproxy#12595)
  network: add io handle recv function for http inspector (envoyproxy#12736)
  jwt_authn: supports jwt payload without "iss" field (envoyproxy#12744)
  Add support for nested JSON format in json logging mode (envoyproxy#12602)
  http: fixing a fuzz flake by setting details on connection teardown (envoyproxy#12737)
  ...

Signed-off-by: Scott LaVigne <lavignes@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants