Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: override msvc-cl config if BAZEL_BUILD_EXTRA_OPTIONS set #12945

Merged
merged 1 commit into from
Sep 7, 2020
Merged

Windows: override msvc-cl config if BAZEL_BUILD_EXTRA_OPTIONS set #12945

merged 1 commit into from
Sep 7, 2020

Conversation

sunjayBhatia
Copy link
Member

Commit Message: Windows: override msvc-cl config if BAZEL_BUILD_EXTRA_OPTIONS set
Additional Description: Will allow us to cleanly add a clang-cl build in CI
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A

@sunjayBhatia
Windows: override msvc-cl config if BAZEL_BUILD_EXTRA_OPTIONS set
b7fc679 
Will allow us to cleanly add a clang-cl build in CI

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia
Copy link
Member Author

@envoyproxy/windows-dev

@sunjayBhatia sunjayBhatia mentioned this pull request Sep 2, 2020
Closed
@sunjayBhatia
Copy link
Member Author

sunjayBhatia commented Sep 2, 2020 •
edited
Loading

@snowp Bill is out this week on vacation

@sunjayBhatia
Copy link
Member Author

Windows RBE pool might be struggling a little

@wrowe wrowe self-requested a review September 2, 2020 18:45
wrowe
wrowe approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@wrowe wrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, permits passing BAZEL_BUILD_EXTRA_OPTIONS to include the toolchain desired. @lizan can you give this an glance and senior-maintainer approval?

@wrowe wrowe requested a review from lizan September 3, 2020 20:03
@lizan lizan merged commit 69cf872 into envoyproxy:master Sep 7, 2020
@sunjayBhatia sunjayBhatia deleted the windows-allow-override-msvc-cl branch September 14, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wrowe wrowe wrowe approved these changes

@lizan lizan lizan approved these changes

Assignees

@wrowe wrowe

Labels
area/build area/windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunjayBhatia @wrowe @lizan