Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored watchdog configuration out of main configuration. #12972

Merged
merged 1 commit into from
Sep 7, 2020

Conversation

KBaichoo
Copy link
Contributor

@KBaichoo KBaichoo commented Sep 3, 2020

Signed-off-by: Kevin Baichoo kbaichoo@google.com

This will enable us to then have multiple watchdog configurations.

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Commit Message: Refactored watchdog configuration out of main configuration.
Additional Description:
Risk Level: low
Testing: ran unit tests
Docs Changes: N/A
Release Notes: N/A
Related #Issue: #12927

Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
Copy link
Contributor

@akonradi akonradi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring!

@KBaichoo
Copy link
Contributor Author

KBaichoo commented Sep 3, 2020

PTAL @envoyproxy/senior-maintainers

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@mattklein123 mattklein123 merged commit 82e611e into envoyproxy:master Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants