tcp: switching to the new pool #13012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
mattklein123
previously approved these changes
Sep 8, 2020
| @@ -99,7 +99,7 @@ New Features | |||
| that track headers and body sizes of requests and responses. | |||
| * stats: allow configuring histogram buckets for stats sinks and admin endpoints that support it. | |||
| * tap: added :ref:`generic body matcher<envoy_v3_api_msg_config.tap.v3.HttpGenericBodyMatch>` to scan http requests and responses for text or hex patterns. | |||
| * tcp: switched the TCP connection pool to the new "shared" connection pool, sharing a common code base with HTTP and HTTP/2. Any unexpected behavioral changes can be temporarily reverted by setting `envoy.reloadable_features.new_tcp_connection_pool` to false. | |||
| * tcp: actually switched the TCP connection pool to the new "shared" connection pool, sharing a common code base with HTTP and HTTP/2. Any unexpected behavioral changes can be temporarily reverted by setting `envoy.reloadable_features.new_tcp_connection_pool` to false. | |||
There was a problem hiding this comment.
Given this hasn't been released yet I would probably skip this part of the change, but up to you. :)
mattklein123
approved these changes
Sep 9, 2020
alyssawilk
added a commit
to alyssawilk/envoy
that referenced
this pull request
Sep 15, 2020
This reverts commit 216a43f. Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
mattklein123
pushed a commit
that referenced
this pull request
Sep 15, 2020
|
This might be breaking for us, more details to follow soon. cc: @fishcakez |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flipping envoy.reloadable_features.new_tcp_connection_pool to true by default
Risk Level: High (but has been successfully smoke tested in prod this time)
Testing: extensive
Docs Changes: n/a
Release Notes:updated relnote we forgot to revert.