Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcp_proxy: API cleanup #13035

Merged
merged 2 commits into from
Sep 10, 2020
Merged

tcp_proxy: API cleanup #13035

merged 2 commits into from
Sep 10, 2020

Conversation

alyssawilk
Copy link
Contributor

Cleaning up an issue where if the TCP proxy session got a Connected event it was problematic.

Risk Level: Low (minor refactor)
Testing: new unit test
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Copy link
Contributor

@ggreenway ggreenway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alyssawilk alyssawilk merged commit 862cc5d into envoyproxy:master Sep 10, 2020
@alyssawilk alyssawilk deleted the todo branch December 10, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants