Shellcheck: bazel/ examples/ and other remaining linting issues #13106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlax
commented
Sep 16, 2020
phlax
commented
Sep 16, 2020
phlax
commented
Sep 16, 2020
phlax
commented
Sep 16, 2020
phlax
commented
Sep 16, 2020
phlax
force-pushed
the
ci-run-shellchecks--rest
branch
3 times, most recently
from
3748b0e to
20b3a28
Compare
phlax
changed the title
phlax
force-pushed
the
ci-run-shellchecks--rest
branch
from
261a3fc to
d8e54e3
Compare
phlax
commented
Sep 21, 2020
| # TODO(asraa): Remove manual `|| true`, but this shouldn't be necessary. | ||
| ${TEST_BINARY} $(find fuzz_corpus -type f) -rss_limit_mb=8192 || true | ||
| # TODO(asraa): Remove manual `|| :`, but this shouldn't be necessary. | ||
| ${TEST_BINARY} "$(find fuzz_corpus -type f)" -rss_limit_mb=8192 || : |
There was a problem hiding this comment.
im wondering if this will handle multiline output from find correctly
There was a problem hiding this comment.
I don't think it does:
$ printf "1: %s, 2: %s\n" $(printf "a\nb\n")
1: a, 2: b
$ printf "1: %s, 2: %s\n" "$(printf "a\nb\n")"
1: a
b, 2:
There was a problem hiding this comment.
which without readarray means this i think
$ _args="$(printf "a\nb\n")"
$ while read -r line; do args+=("$line"); done \
<<< "$_args"
$ printf "1: %s, 2: %s\n" "${args[@]}"
1: a, 2: b
phlax
force-pushed
the
ci-run-shellchecks--rest
branch
from
2a22d6f to
de07a44
Compare
phlax
changed the title
phlax
commented
Sep 23, 2020
phlax
commented
Sep 23, 2020
|
im thinking that #12889 should probably land before this one as i think one or other will need to rebase |
phlax
commented
Sep 23, 2020
|
This looks good to me. Do you want to hold it until #12889 lands? |
yep waiting...
|
phlax
force-pushed
the
ci-run-shellchecks--rest
branch
from
705d19b to
409f62e
Compare
|
/azp run |
|
Command 'rerun' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
|
Commenter does not have sufficient privileges for PR 13106 in repo envoyproxy/envoy |
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
this fails locally but not in ci - perhaps shellcheck version Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
ci-run-shellchecks--rest
branch
from
ec49ff3 to
004ac11
Compare
|
Is this ready to go now? |
|
yep |
zuercher
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Shellcheck: bazel/ examples/
Additional Description:
Remaining shellcheck cleanups
Risk Level: low
Testing:
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue] fixes #7793
[Optional Deprecated:]