log: improvements to sparse macros, fancy logger. #13223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by a log statement needed for envoyproxy#10815, this patch: * Adds _MISC variants of sparse macros. * Sends _MISC log messages to fancy logger (these were previously ignored). This is a bit weird, as "misc" is also a logger and we use file-specific loggers in fancy logger, but in reality, most folks treat this macro as the generic Envoy log statement. * Avoid evaluating expressions in ENVOY_LOG* with fancy logger when beneath the configured log level. Risk level: Low Testing: Mostly covered by log_macros_test already, added some _MISC coverage in SparseLogMacrosTest. Signed-off-by: Harvey Tuch <htuch@google.com>
oschaaf
reviewed
Sep 22, 2020
source/common/common/fancy_logger.cc
Outdated
| @@ -90,6 +90,15 @@ void FancyContext::setAllFancyLoggers(spdlog::level::level_enum level) | |||
| } | |||
| } | |||
|
|
|||
| FancyLogLevelMap FancyContext::getAllFancyLogLevels() ABSL_LOCKS_EXCLUDED(fancy_log_lock_) { | |||
There was a problem hiding this comment.
I lack some context here, but if this is a production code utility, would this deserve a unit test of its own, and maybe add caching to it?
If not, would it be worth considering moving this into test/ as right now it's only used there?
I don't want to bloat this PR, just curious.
There was a problem hiding this comment.
fancy_logger.h comments say this is test only, I don't mind renaming to getAllFancyLogLevelsForTest() if that makes it clearer. Not sure how to move it out of this file as it needs access to internal fields.
There was a problem hiding this comment.
Yes, please name test-only code as such. Makes it much easier to understand.
oschaaf
previously approved these changes
Sep 23, 2020
ggreenway
requested changes
Sep 24, 2020
Signed-off-by: Harvey Tuch <htuch@google.com>
ggreenway
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by a log statement needed for #10815, this patch:
Adds _MISC variants of sparse macros.
Sends _MISC log messages to fancy logger (these were previously
ignored). This is a bit weird, as "misc" is also a logger and
we use file-specific loggers in fancy logger, but in reality, most
folks treat this macro as the generic Envoy log statement.
Avoid evaluating expressions in ENVOY_LOG* with fancy logger when
beneath the configured log level.
Risk level: Low
Testing: Mostly covered by log_macros_test already, added some _MISC
coverage in SparseLogMacrosTest.
Signed-off-by: Harvey Tuch htuch@google.com