-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Documentation] Adds Sphnix-copy-button & sphnix-tabs to docs #13239
Conversation
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
@phlax let me know what you think. cc: @envoyproxy/windows-dev this should be useful for Windows vs POSIX documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks great - i think ssh
should be first tho.
Nice one for throwing in copybutton
i was looking at that earlier and wondering
It might be easier waiting till #13230 has landed - just in terms of making changes - but im happy to rebase if necessary - defo not a blocker
|
||
or | ||
.. code-tab:: console HTTPS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im thinking we probably want ssh
first on the basis that most people following these instructions are devs and have a github acc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just did it that way because of GitHub. But it makes sense for us to have them the opposite way. I will change that.
is it easy/possible to disable copybutton for some blocks ? for the interactive console stuff it makes less sense - brilliant for config tho! |
maybe im wrong about that - ideal would be that you can copy single lines i think (and perhaps link to them) - not sure how plugin works |
I added the regex for bash so it is actually pretty smart. For example in the Snippet:
The pasted output is:
|
yep - thats pretty cool |
re: rebase after #13230, I also dont mind rebasing. It is the same for me. |
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
@davinci26 not sure why the test failed (ran out of disk space) - i dont think its because of changes in your PR (might be wrong). either way - its hung the test instance - adding an empty commit would kick the ci and i think kill the dead server instance |
/retest |
Retrying Azure Pipelines, to retry CircleCI checks, use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat, I will just force merge this while we sort out unrelated CI issues.
Signed-off-by: Sotiris Nanopoulos sonanopo@microsoft.com
Fixes #13213
Major changes:
Additional Description:
This is how it looks now.
refs:
Risk Level: Low
Testing: Manually
Docs Changes: N/A
Release Notes: N/A