Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Use structured headings for examples steps #13292

Merged

Conversation

phlax
Copy link
Member

@phlax phlax commented Sep 28, 2020

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message: docs: Use structured headings for examples steps
Additional Description:

atm, the examples docs use **...** for the steps headings - i think this just makes them bold.

this PR switches to using structured headings for the steps

Risk Level: low
Testing:
Docs Changes: yep
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax force-pushed the docs-examples-structured-headings branch from 077a45c to d108fd9 Compare September 28, 2020 07:22
@phlax phlax changed the title [WIP] docs: Use structured headings for examples steps docs: Use structured headings for examples steps Sep 28, 2020
@phlax
Copy link
Member Author

phlax commented Sep 28, 2020

If you are logged in to circleci - you can see the rendered docs here:

https://385172-65214191-gh.circle-artifacts.com/0/generated/docs/start/start.html#sandboxes

@mattklein123 mattklein123 self-assigned this Sep 28, 2020
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit 392ce7c into envoyproxy:master Sep 28, 2020
@phlax phlax mentioned this pull request Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants