Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: associate extensions with deps, validate use_category. #13340

Merged
merged 7 commits into from
Oct 1, 2020

Commits on Sep 30, 2020

  1. dependencies: associate extensions with deps, validate use_category.

    This PR introduces a few related changes:
    
    * use_category is restructured to distinguish core/extension deps. There's also an extension
      allowlist added for each dependency in the dataplane_ext and observability_ext category.
    
    * tools/dependency/validate.py is introduced to validate a bunch of structural relationships
      implied by the bazel/repository_locations.bzl metadata. This includes that test-only deps
      aren't used in //source/.., that some obvious dataplane/controlplane packages taint the
      appropriate reachable deps and that the association between extensions/deps holds.
    
    * The CI docs jobs now runs tools/dependency/validate.py.
    
    * The dependency dashboard at
      https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/security/external_deps
      to include granular information on which dataplane/observability deps come from core/extensions.
    
    * Some misc. cleanup of source code dep that came up while working on this.
    
    Risk level: Low
    Testing: Pyunit tests added for validate.py.
    
    Part of envoyproxy#12673.
    
    Signed-off-by: Harvey Tuch <htuch@google.com>
    htuch committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    e281064 View commit details
    Browse the repository at this point in the history
  2. Typo.

    Signed-off-by: Harvey Tuch <htuch@google.com>
    htuch committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    87c8fb4 View commit details
    Browse the repository at this point in the history
  3. zlib-ng {version} conversion.

    Signed-off-by: Harvey Tuch <htuch@google.com>
    htuch committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    bed8fcf View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. Fix release builds.

    Signed-off-by: Harvey Tuch <htuch@google.com>
    htuch committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    0e5d347 View commit details
    Browse the repository at this point in the history
  2. One more for the road.

    Signed-off-by: Harvey Tuch <htuch@google.com>
    htuch committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    7895d13 View commit details
    Browse the repository at this point in the history
  3. Review feedback.

    Signed-off-by: Harvey Tuch <htuch@google.com>
    htuch committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    49791ec View commit details
    Browse the repository at this point in the history
  4. Cleaner.

    Signed-off-by: Harvey Tuch <htuch@google.com>
    htuch committed Oct 1, 2020
    4 Configuration menu
    Copy the full SHA
    71a9c7f View commit details
    Browse the repository at this point in the history