dependencies: enhance CVE and version links. #13434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* CPE link now performs NIST search on all CVEs, rather than linking to a collection of version CPEs and requiring the user to click on each for CVEs. * Version links now point to GitHub release tag pages or the GitHub tree at a particular hash for SHA versions. Previously this was just the tarball download. For non-GitHub blobs, e.g. on GCS, we still just provide the tarball download link. Risk level: Low Testing: Manual clicking on links, seems to work for NIST CVEs and a wide number of sampled tagged release versions. Part of envoyproxy#12673 Signed-off-by: Harvey Tuch <htuch@google.com>
|
Ran a test and LGTM. Good to not link directly to the tarball (where possible) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CPE link now performs NIST search on all CVEs, rather than linking to
a collection of version CPEs and requiring the user to click on each
for CVEs.
Version links now point to GitHub release tag pages or the GitHub
tree at a particular hash for SHA versions. Previously this was just
the tarball download. For non-GitHub blobs, e.g. on GCS, we still just
provide the tarball download link.
Risk level: Low
Testing: Manual clicking on links, seems to work for NIST CVEs and a
wide number of sampled tagged release versions.
Part of #12673
Signed-off-by: Harvey Tuch htuch@google.com