memory: enable tcmalloc for aarch64 #13830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update dependency on Abseil required for newer tcmalloc. Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
repokitteh-read-only
bot
added
the
deps
|
You might consider bumping Abseil to the latest Oct 29 commit - abseil/abseil-cpp@e9b9e38 |
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
|
Dependency updates LGTM. Can approve when this comes out of Draft |
|
/retest |
|
Retrying Azure Pipelines: |
|
/retest |
|
Retrying Azure Pipelines: |
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
jmarantz
previously approved these changes
Nov 5, 2020
jmarantz
reviewed
Nov 5, 2020
|
Yeah, I'm still trying to figure out what combination of dep versions builds Ok. :) Hopefully the last commit fixes everything. |
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
|
@moderation @jmarantz This is ready for review finally. |
|
Abseil cannot be updated to the latest HEAD due to #13973 |
lizan
previously approved these changes
Nov 12, 2020
moderation
suggested changes
Nov 12, 2020
bazel/repository_locations.bzl
Outdated
| strip_prefix = "abseil-cpp-{version}", | ||
| urls = ["https://github.com/abseil/abseil-cpp/archive/{version}.tar.gz"], | ||
| use_category = ["dataplane_core", "controlplane"], | ||
| release_date = "2020-10-01", | ||
| release_date = "2020-10-16", |
There was a problem hiding this comment.
I think the UTC for this commit is 2020-10-17
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
|
/lgtm deps |
repokitteh-read-only
bot
removed
the
deps
jmarantz
approved these changes
Nov 12, 2020
|
@envoyproxy/senior-maintainers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: memory: enable tcmalloc for aarch64
Additional Description: Also update dependency on Abseil required for newer tcmalloc.
Risk Level: Low
Testing: CI tests
Docs Changes: N/A
Release Notes: updated current.rst
Platform Specific Features: N/A
Contributes to #10053