docs: document attributes for RBAC and Wasm #13971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
htuch
suggested changes
Nov 12, 2020
kyessenov
commented
Nov 12, 2020
|
/retest |
|
Retrying Azure Pipelines: |
htuch
reviewed
Nov 13, 2020
| * `uint` for 64-bit unsigned integers | ||
| * `bool` for booleans | ||
| * `list` for lists of values | ||
| * `map` for associative arrays with string, integer, or boolean keys |
There was a problem hiding this comment.
Do we ever use integer or boolean keys? The main reason I ask is that with ext_proc, this is a Struct, which is a JSON dictionary.
There was a problem hiding this comment.
No, we don't. I think it's fine to say it's always string keys.
Signed-off-by: Kuat Yessenov <kuat@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kuat Yessenov kuat@google.com
cc @htuch @PiotrSikora
Commit Message: Organize the list of attributes better
Additional Description:
Risk Level: none
Testing: none
Docs Changes:
Release Notes:
Platform Specific Features: