backport to 1.16: udp: properly handle truncated/dropped datagrams #14124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Christoph Pakulski <christoph@tetrate.io> Signed-off-by: phlax <phlax@users.noreply.github.com>
The client request stream can be deleted under the call stack of Envoy::IntegrationCodecClient::startRequest if the proxy replies quickly enough. Attempts to send an end stream on that request result in use-after-free on the client stream in cases where the client processed the full reply inside startRequest. Fixes envoyproxy#12960 Signed-off-by: Antonio Vicente <avd@google.com> Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
* udp: properly handle truncated/dropped datagrams Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
mattklein123
approved these changes
Nov 20, 2020
| @@ -1,5 +1,5 @@ | |||
| 1.16.1 (Pending) | |||
| ================ | |||
| 1.16.1 (November 20, 2020) | |||
There was a problem hiding this comment.
Note all of these need to get merged to main at some point, so please make a note on that.
| @@ -8,13 +8,13 @@ static_resources: | |||
| - filters: | |||
| - name: envoy.filters.network.http_connection_manager | |||
| typed_config: | |||
| "@type": type.googleapis.com/envoy.config.filter.network.http_connection_manager.v2.HttpConnectionManager | |||
| "@type": type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager | |||
There was a problem hiding this comment.
It would be better if this change is a separate PR but not a crisis.
There was a problem hiding this comment.
OK. Created #14125, which to be merged to release/v1.16 first and I will create a new PR for UDP fix.
There was a problem hiding this comment.
Created yet another PR #14127 for @antoniovicente fix to auth coverage test. I am going to close this PR, wait until the other two are merged to release/v1.16 and create a new PR just for UDP fixes.
|
Closing: this PR is replaced by #14130. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
properly handle truncated/dropped datagrams
Also fixes examples to use v3.
Additional Description:
Risk Level: Med
Testing:Unit tests
Docs Changes: No
Release Notes: Yes