Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: new external dep policy. #14334

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Conversation

htuch
Copy link
Member

@htuch htuch commented Dec 8, 2020

This patch converts
https://docs.google.com/document/d/1HbREo7pv7rgeIIjQn6mNpySzQE5rx2Yv9dXm5NqR2N8/edit#
to Markdown and provides a PR-based review of the policy, following
discussion in the doc and various offline threads.

Fixes #10471

Signed-off-by: Harvey Tuch htuch@google.com

This patch converts
https://docs.google.com/document/d/1HbREo7pv7rgeIIjQn6mNpySzQE5rx2Yv9dXm5NqR2N8/edit#
to Markdown and provides a PR-based review of the policy, following
discussion in the doc and various offline threads.

Fixes envoyproxy#10471

Signed-off-by: Harvey Tuch <htuch@google.com>
@htuch
Copy link
Member Author

htuch commented Dec 8, 2020

CC @envoyproxy/maintainers @envoyproxy/security-team @envoyproxy/dependency-shepherds

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@moderation
Copy link
Contributor

Looks great. Thanks

Copy link
Contributor

@moderation moderation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@htuch htuch merged commit 709414b into envoyproxy:master Dec 11, 2020
@htuch htuch deleted the dep-policy branch December 11, 2020 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External dependency release maturity
4 participants