network: update network test-coverage expectations and add one simple coverage improvement #14547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Marantz <jmarantz@google.com>
mattklein123
reviewed
Jan 2, 2021
| @@ -14,7 +14,7 @@ declare -a KNOWN_LOW_COVERAGE=( | |||
| "source/common/http/http3:50.0" | |||
| "source/common/init:96.4" | |||
| "source/common/json:90.6" | |||
| "source/common/network:95.3" | |||
| "source/common/network:95.1" | |||
There was a problem hiding this comment.
Did you mean to drop this lower?
/wait-any
There was a problem hiding this comment.
Yes I meant to revert the effects of #14472 on this particular directory. I think Alyssa's earlier "ratcheting" PR was a bit aggressive and there's something flaky in this test-tree that affects coverage.
I don't think my opportunistic simplification in transport_socket_options_impl.cc will reliably get us closer to 95.3. I think the main issue in this directory is a bunch of constexpr conditionals that were added recently.
mattklein123
approved these changes
Jan 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: It looks like #14472 brought us to the edge of coverage passing for source/common/network, so this reverts the change to that expectation. I also found one easy savings of a few lines of missing coverage by removing some redundant if statements.
Additional Description:
Risk Level: low
Testing: test/common/network/...
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a