config: Listener v1 JSON -> proto translation. #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last of the summer wine.
|
@mattklein123 This is ready for review, but there is one remaining issue to iron out before we merge. I think we might be able to simplify the stuff around |
|
Thanks. I reckon let's merge, as it unblocks the LDS Subscription work and as long as we're ingesting v1 JSON it doesn't make a difference. |
mattklein123
approved these changes
Aug 16, 2017
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: It's critical that postinit setup is thread-safe relative to the dispatcher, but we can't actually call Event::Dispatcher::isThreadSafe() because it blows up at this juncture. This safety check is leveraged elsewhere by Envoy to execution is happening on the main thread regardless of dispatch. Risk Level: Low Testing: Local and CI Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: It's critical that postinit setup is thread-safe relative to the dispatcher, but we can't actually call Event::Dispatcher::isThreadSafe() because it blows up at this juncture. This safety check is leveraged elsewhere by Envoy to execution is happening on the main thread regardless of dispatch. Risk Level: Low Testing: Local and CI Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last of the summer wine.