Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Move docs/build.sh to bazel #15229

Merged
merged 1 commit into from
Jun 22, 2021
Merged

docs: Move docs/build.sh to bazel #15229

merged 1 commit into from
Jun 22, 2021

Conversation

phlax
Copy link
Member

@phlax phlax commented Feb 28, 2021 •
edited
Loading

Commit Message: docs: Move docs/build.sh to bazel
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] Fix #13229
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #15229 was opened by phlax.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Feb 28, 2021
@phlax phlax marked this pull request as draft February 28, 2021 12:58
@phlax phlax force-pushed the docs-bazel-build branch 4 times, most recently from bf42599 to e6c9fdd Compare March 1, 2021 10:44
@alyssawilk
Copy link
Contributor

ping back when this is ready for review!

@phlax phlax force-pushed the docs-bazel-build branch 6 times, most recently from 4defa66 to 341399c Compare March 5, 2021 06:15
@mattklein123 mattklein123 self-assigned this Mar 14, 2021
@phlax phlax force-pushed the docs-bazel-build branch from 341399c to d7df173 Compare March 15, 2021 04:22
@phlax phlax force-pushed the docs-bazel-build branch from 205126d to dd31c21 Compare March 15, 2021 04:33
@phlax
Copy link
Member Author

phlax commented Mar 15, 2021

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #15229 (comment) was created by @phlax.

see: more, trace.

phlax
phlax commented Mar 16, 2021
View reviewed changes
bazel/repositories_extra.bzl Outdated Show resolved Hide resolved
phlax
phlax commented Mar 16, 2021
View reviewed changes
docs/build.py Outdated Show resolved Hide resolved
phlax
phlax commented Mar 16, 2021
View reviewed changes
docs/build.sh Outdated Show resolved Hide resolved
phlax
phlax commented Mar 16, 2021
View reviewed changes
docs/requirements.txt Outdated Show resolved Hide resolved
phlax
phlax commented Mar 16, 2021
View reviewed changes
tools/api/BUILD Outdated Show resolved Hide resolved
@phlax phlax force-pushed the docs-bazel-build branch from 8919ffc to 73b6b62 Compare April 7, 2021 14:42
@phlax phlax mentioned this pull request Jun 13, 2021
Merged
@phlax phlax force-pushed the docs-bazel-build branch 5 times, most recently from 1f96888 to 20d9c96 Compare June 14, 2021 13:38
@phlax phlax force-pushed the docs-bazel-build branch from 20d9c96 to ff44487 Compare June 15, 2021 23:04
phlax
phlax commented Jun 15, 2021
View reviewed changes
docs/build.sh Outdated Show resolved Hide resolved
phlax
phlax commented Jun 15, 2021
View reviewed changes
tools/docs/sphinx_runner.py Outdated Show resolved Hide resolved
phlax
phlax commented Jun 15, 2021
View reviewed changes
tools/docs/sphinx_runner.py Outdated Show resolved Hide resolved
phlax
phlax commented Jun 15, 2021
View reviewed changes
tools/docs/sphinx_runner.py Outdated Show resolved Hide resolved
phlax
phlax commented Jun 15, 2021
View reviewed changes
docs/BUILD Outdated Show resolved Hide resolved
@phlax phlax mentioned this pull request Jun 16, 2021
Closed
@phlax phlax force-pushed the docs-bazel-build branch 2 times, most recently from 171b5ac to 8522044 Compare June 21, 2021 15:32
@phlax phlax changed the title [WIP] docs: Move docs/build.sh to bazel docs: Move docs/build.sh to bazel Jun 21, 2021
@phlax
Copy link
Member Author

phlax commented Jun 21, 2021

ping back when this is ready for review!

@alyssawilk ping!

@htuch this is the final part in the move to building docs with bazel - should be ready for review!

@alyssawilk
Copy link
Contributor

Still looks like a draft? per multiple requests I'm going to switch our tooling to ignore them, so maybe de-draft?
I'll let @htuch take a look either way since he's reviewer and Matt's out.

@phlax phlax marked this pull request as ready for review June 21, 2021 15:37
@phlax
Copy link
Member Author

phlax commented Jun 21, 2021

Still looks like a draft?

oops - done

@phlax
docs: Shift build to bazel and python
37643d2 
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax force-pushed the docs-bazel-build branch from 8522044 to 37643d2 Compare June 21, 2021 17:42
htuch
htuch approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice!

@htuch htuch merged commit f8d8023 into envoyproxy:main Jun 22, 2021
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
@phlax
docs: Shift build to bazel and python (envoyproxy#15229)
748afc0 
Signed-off-by: Ryan Northey <ryan@synca.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitri-d dmitri-d dmitri-d left review comments

@htuch htuch htuch approved these changes

Assignees

@adisuissa adisuissa

@mattklein123 mattklein123

@htuch htuch

Labels
api deps Approval required for changes to Envoy's external dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make it easier to build docs
6 participants
@phlax @alyssawilk @dmitri-d @htuch @adisuissa @mattklein123