wasm: enable on Linux-aarch64 and macOS-arm64. #15253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repokitteh-read-only
bot
added
the
deps
PiotrSikora
force-pushed
the
wasm-aarch64
branch
4 times, most recently
from
584027d
to
fe4a46c
Compare
PiotrSikora
changed the title
PiotrSikora
changed the title
Skip Proxy-Wasm C++ SDK tests, since they require Emscripten, which doesn't provide releases for arm64. Addresses envoyproxy#14027. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora
force-pushed
the
wasm-aarch64
branch
from
fe4a46c
to
6ffc8fd
Compare
Alternatives include: |
|
NOTE: macOS-arm64 build is not tested, since I don't have access to the hardware, but I believe it should work... It would be great if someone could test it before we merge it, though. |
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
|
/retest |
|
Retrying Azure Pipelines: |
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
|
/retest |
|
Retrying Azure Pipelines: |
|
/lgtm deps |
repokitteh-read-only
bot
removed
the
deps
moderation
approved these changes
Mar 4, 2021
lizan
approved these changes
Mar 5, 2021
mathetake
approved these changes
Mar 5, 2021
PiotrSikora
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip Proxy-Wasm C++ SDK tests, since they require Emscripten,
which doesn't provide releases for arm64.
Addresses #14027.
Signed-off-by: Piotr Sikora piotrsikora@google.com