http: sending the original url scheme (or best guess) upstream. #15321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
mattklein123
requested changes
Mar 4, 2021
source/common/router/router.cc
Outdated
| return; | ||
| } | ||
| } | ||
| bool transport_secure = |
There was a problem hiding this comment.
nit: const downstream_transport_secure
|
oh yeah, I meant to move the warning to the top because of risk. will dot that now. |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
|
sorry, lost my LGTM with tidy and accidentally force pushed a delta but I think your review state should all be there |
auni53
pushed a commit
to auni53/envoy
that referenced
this pull request
Mar 19, 2021
…yproxy#15321) This replaces prior logic where the :scheme header was consistently overwritten based on the encryption level of the upstream connection. Risk Level: High (l7 change) Testing: new integration tests, unit tests Docs Changes: api docs updated Release Notes: inline Runtime guard: envoy.reloadable_features.preserve_downstream_scheme Part of envoyproxy#14587 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Auni Ahsan <auni@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces prior logic where the :scheme header was consistently overwritten based on the encryption level of the upstream connection.
Risk Level: High (l7 change)
Testing: new integration tests, unit tests
Docs Changes: api docs updated
Release Notes: inline
Runtime guard: envoy.reloadable_features.preserve_downstream_scheme
Part of #14587