Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: Simplify select alias configuration #15797

Conversation

keith
Copy link
Member

@keith keith commented Apr 1, 2021

When this was added originally this skylib helper didn't exist.

Signed-off-by: Keith Smiley keithbsmiley@gmail.com

When this was added originally this skylib helper didn't exist.

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Check CI?

/wait

bazel/BUILD Show resolved Hide resolved
I think this requires bazel 4.0

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
This way we always use the correct setting

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Did you want to make any more changes to this?

@keith keith marked this pull request as ready for review April 1, 2021 21:32
@keith
Copy link
Member Author

keith commented Apr 1, 2021

nope I think we're good here, thanks!

@mattklein123 mattklein123 merged commit cfc04c4 into envoyproxy:main Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants