h2 recv buffer coverage #1608
Merged
h2 recv buffer coverage #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htuch
reviewed
Sep 7, 2017
| @@ -502,6 +502,28 @@ TEST_P(Http2CodecImplFlowControlTest, EarlyResetRestoresWindow) { | |||
| EXPECT_EQ(initial_connection_window, nghttp2_session_get_remote_window_size(client_.session())); | |||
| } | |||
|
|
|||
| TEST_P(Http2CodecImplFlowControlTest, FlowControlPendingRecvData) { | |||
There was a problem hiding this comment.
Can you add a one line // above explaining what is being validated? In general I prefer all tests to have this when non-trivial.
htuch
approved these changes
Sep 7, 2017
|
@alyssawilk I think the CLA tool was made more robust so you will need to "verify" your GH email address. (Basically if you look at your commits you will need to get rid of the '?' next to your name). |
|
Oh weird, something I set up when I was doing QUIC commits for Chrome latched on to my chromium.org address instead of google.com. I have no idea what part of the system has the "wrong" address but it'd be a pain to switch it's easy enough to verify :-) |
mattklein123
approved these changes
Sep 7, 2017
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Propercasing both request and response path for the ALPN pool Risk Level: low (alpn-pool only) Testing: n/a Docs Changes: n/a Release Notes: n/a Fixes #1558 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Propercasing both request and response path for the ALPN pool Risk Level: low (alpn-pool only) Testing: n/a Docs Changes: n/a Release Notes: n/a Fixes #1558 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ask and ye shall receive :-)
Vaguely part of #150