-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI dependencies #165
Conversation
wget https://github.com/gabime/spdlog/archive/v0.11.0.tar.gz | ||
tar xf v0.11.0.tar.gz | ||
rm v0.11.0.tar.gz | ||
mv spdlog-0.11.0 spdlog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's leave as spdlog-0.11.0 and update do_ci.sh to point to this directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please push new build image once merged
* Delay sendLocalReply till after the call to prevent rentrant calls. (envoyproxy#432) Signed-off-by: John Plevyak <jplevyak@gmail.com> * Add missing deferred operation handlers. Signed-off-by: John Plevyak <jplevyak@gmail.com>
…filter zh-translation: docs/root/intro/arch_overview/security/ext_authz_filt…
We're not yet able to have specific kotlin and java directory specific rules just yet because of the transitive dependency problem highlighted in the comment. Signed-off-by: Alan Chiu <achiu@lyft.com> For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md) Description: move aar build specific rules into the `library/BUILD` Risk Level: low Testing: ci, local Docs Changes: na Release Notes: na [Optional Fixes #Issue] [Optional Deprecated:] Signed-off-by: JP Simard <jp@jpsim.com>
We're not yet able to have specific kotlin and java directory specific rules just yet because of the transitive dependency problem highlighted in the comment. Signed-off-by: Alan Chiu <achiu@lyft.com> For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md) Description: move aar build specific rules into the `library/BUILD` Risk Level: low Testing: ci, local Docs Changes: na Release Notes: na [Optional Fixes #Issue] [Optional Deprecated:] Signed-off-by: JP Simard <jp@jpsim.com>
Co-authored-by: José Carlos Chávez <jcchavezs@gmail.com>
I have tested this by making a new
lyft/envoy-build
image and compiling withdocker run -t -i -v <SOURCE_DIR>:/source lyft/envoy-build:latest /bin/bash -c "cd /source && ci/do_ci.sh normal"
I'll push to dockerhub once we merge this.