Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "bazel: update DEPS on googleurl" #17957

Closed

Conversation

RenjieTang
Copy link
Contributor

@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #17957 was opened by RenjieTang.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Sep 1, 2021
@wrowe
Copy link
Contributor

wrowe commented Sep 1, 2021

Please fix DCO and I'll expedite. Drat.

@moderation
Copy link
Contributor

We've had multiple merge and reversions with rules_foreign_cc (https://github.com/envoyproxy/envoy/pulls?q=is%3Apr+rules_foreign_cc+is%3Aclosed+sort%3Aupdated-desc+) due to Envoy Mobile CI breakage.

Do we or is there any way to surface these breakages as part of normal CI and before PRs get merged? /cc @junr03

@wrowe
Copy link
Contributor

wrowe commented Sep 2, 2021

Alternate possibility, does it make sense to anchor envoy-mobile to the prior working commit of envoy, and work the issues locally on an envoy-mobile branch?

@RenjieTang
Copy link
Contributor Author

I'm having trouble pulling this PR to my local machine. So I created #17958 to fix the DCO.

@RenjieTang RenjieTang closed this Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Approval required for changes to Envoy's external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants