Listener: fix a crash when updating any listener that does not bind to port #18421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdai
changed the title
|
@lizan since this is blocking istio-proxy from picking up the change. |
|
ref: istio/istio#34188 |
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
mattklein123
requested changes
Oct 5, 2021
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
|
/retest |
|
Retrying Azure Pipelines: |
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
mattklein123
reviewed
Oct 5, 2021
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
mattklein123
reviewed
Oct 6, 2021
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
|
LGTM but unfortunately needs another main merge. /wait |
Thanks! Just did it |
|
@mattklein123 Thank you for the fast and friendly collaboration! |
|
I see conflict show up again at WebUI but my origin/main is updated. I will keep watch on this |
|
@lambdai do we want to backport this to 1.20.x? |
yes, I plan to propose /backport when this is merged. |
|
Should I do it earlier? |
|
/backport |
repokitteh-read-only
bot
added
the
backport/review
|
@lizan @mathetake This is 1.20 only and it's critical for istio release See istio/istio#34188 I can create the PR when this one is merged. WDTY? |
lambdai
added a commit
to lambdai/envoy-dai
that referenced
this pull request
Oct 7, 2021
…o port (envoyproxy#18421) Signed-off-by: Yuchen Dai <silentdai@gmail.com>
|
@mathetake is OOO Yes we should backport this to 1.20.x |
mathetake
pushed a commit
that referenced
this pull request
Oct 18, 2021
…o port (#18421) (#18505) backport e84987c to v1.20 Fix the crash caused by listener update when the any listener set bind_to_port to false. A listener does not bind to port has no io handle. close() already check it. Now add the check to isOpen(). Also the Tcp(or Udp)ListenSocket::duplicate() creates parent ListenSocketImpl Make it returning the derived ListenSocket, either TcpListenSocket or UdpListenSocket Signed-off-by: Yuchen Dai <silentdai@gmail.com>
alyssawilk
added
backport/approved
aidanhahn
pushed a commit
to datawire/envoy
that referenced
this pull request
Jan 13, 2022
…o port (envoyproxy#18421) (envoyproxy#18505) backport e84987c to v1.20 Fix the crash caused by listener update when the any listener set bind_to_port to false. A listener does not bind to port has no io handle. close() already check it. Now add the check to isOpen(). Also the Tcp(or Udp)ListenSocket::duplicate() creates parent ListenSocketImpl Make it returning the derived ListenSocket, either TcpListenSocket or UdpListenSocket Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Fix the crash caused by listener update when the any listener set bind_to_port to false.
A listener does not bind to port has no io handle. close() already check it.
Now add the check to isOpen().
Also the Tcp(or Udp)ListenSocket::duplicate() creates parent ListenSocketImpl
Make it returning the derived ListenSocket, either TcpListenSocket or UdpListenSocket
Additional Description:
Risk Level:
Testing: Unit test on duplicate. Integration test on bind_to_port.
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]