formatter: escape percent sign in response format

[aidanhahn]

Add a case in the SubstitutionFormatter to replace '%%' with '%'.
This allows users to escape % in their configurations, fixing #15159.

Signed-off-by: Aidan Hahn aidanhahn@datawire.io

Commit Message: formatter: escape percent sign in response format
Additional Description:
Risk Level: Low
Testing: Unit testing
Docs Changes:
Release Notes:
Platform Specific Features:
Fixes: #15159

[repokitteh-read-only]

Hi @aidanhahn, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #19383 was opened by aidanhahn.

see: more, trace.

[jmarantz]

/assign-from @envoyproxy/first-pass-reviewers

Can you clean up the description (remove optional fields and hints)?

[repokitteh-read-only]

@envoyproxy/first-pass-reviewers assignee is @jmarantz

🐱

Caused by: a #19383 (comment) was created by @jmarantz.

see: more, trace.

[jmarantz]

Also, please don't force-push. More detail about this will be added to the developers doc in #19381

[aidanhahn]

I have //test/integration:buffer_accounting_integration_test passing in my local environment. Could it be a flake? Is there a way I can re-trigger the CI tests?

[rojkov]

To rerun failed checks without making changes just add this line in a comment:

/retest

More info on this is in https://github.com/envoyproxy/envoy/blob/main/CONTRIBUTING.md#triggering-ci-re-run-without-making-changes

[repokitteh-read-only]

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #19383 (comment) was created by @rojkov.

see: more, trace.

[jmarantz]

I found a few superficial nits but I think this needs a look from someone who's worked with the formatters before.

[aidanhahn]

Previously you mentioned I should not force push, is it acceptable to force push in order to fix DCO?

[jmarantz]

That's the only reason to do it, but generally you should not have DCO problems if you set up the right git hooks.

The main reason it's OK to force-push to fix DCO is that usually happens exactly once, before anyone has started reviewing. If you force-push after people start reviewing it wipes out their comments.

So my suggestion is to force-push this time, but install the git hooks so this never needs to happen again, and we'll live with my precious review being wiped :)

[aidanhahn]

/retest

[repokitteh-read-only]

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #19383 (comment) was created by @aidanhahn.

see: more, trace.

[jmarantz]

/wait

[github-actions]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

[github-actions]

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!