mobile: consistently compiling out admin code

[alyssawilk]

Changing the default E-M build to not include the admin interface. It is enabled for swift CI due to regression tests.

Risk Level: low
Testing: CI
Docs Changes: n/a
Release Notes: n/a

[repokitteh-read-only]

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #24364 was opened by alyssawilk.

see: more, trace.

[repokitteh-read-only]

CC @envoyproxy/mobile-maintainers: FYI only for changes made to (mobile/).
envoyproxy/mobile-maintainers assignee is @abeyad

🐱

Caused by: #24364 was opened by alyssawilk.

see: more, trace.

[alyssawilk]

@jpsim @Augustyniak if I fix up the C++ tests to work sans admin, what do you folks think about landing this, vs switching only some of the CI bots to not include admin?

[jpsim]

if I fix up the C++ tests to work sans admin, what do you folks think about landing this, vs switching only some of the CI bots to not include admin?

I think we agreed at a community meeting a while back that an end-goal should be to remove admin entirely, exposing programmatic interfaces to access stats instead whenever it's useful.

So I'm definitely onboard with finding a way to never need admin to be enabled.

[Augustyniak]

Fine with landing this.

I think we agreed at a community meeting a while back that an end-goal should be to remove admin entirely, exposing programmatic interfaces to access stats instead whenever it's useful.

During the aforementioned community call I mentioned that I use admin endpoint for the purpose of local dev (when working with stats specifically). While I think that admin should be disabled by default I would be more for keeping an option to enable it as needed if possible at least until we figure out programatic interfaces for accessing stats.

[alyssawilk]

/retest

[repokitteh-read-only]

Retrying Azure Pipelines:
Check envoy-presubmit didn't fail.

🐱

Caused by: a #24364 (comment) was created by @alyssawilk.

see: more, trace.

[alyssawilk]

/retest

[repokitteh-read-only]

Retrying Azure Pipelines:
Check envoy-presubmit didn't fail.

🐱

Caused by: a #24364 (comment) was created by @alyssawilk.

see: more, trace.

[RyanTheOptimist]

Nice!

[abeyad]

Probably want to change the title of the PR to remove "WIP"

[abeyad]

/retest

[repokitteh-read-only]

Retrying Azure Pipelines:
Check envoy-presubmit didn't fail.

🐱

Caused by: a #24364 (comment) was created by @abeyad.

see: more, trace.