kafka: fetch request #24606
Merged
kafka: fetch request #24606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
adamkotwasinski
force-pushed
the
kafka-fetch
branch
from
a86cebb to
653e015
Compare
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
|
/assign @mattklein123 |
mattklein123
approved these changes
Jan 27, 2023
|
Thank you! |
VishalDamgude
pushed a commit
to freshworks/envoy
that referenced
this pull request
Feb 2, 2023
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Aug 22, 2023
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Aug 25, 2023
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com> Signed-off-by: Ryan Northey <ryan@synca.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: kafka: add Fetch request handling
Additional Description: Fetch request represents a single request coming from downstream clients "please give me records for partitions p1, p2, ... pN". In our implementation this will mean we will ask SharedConsumerManager to process our request (== fill it with records, if any stored; register as callback if nothing). When our processing is finished (which can happen in one of two ways: record times out (no records!) / stuff got provided (either initial seeding or by SCM's consumer workers), we finally let the filter/dispatcher know we are ready to go downstream. Part of #24372.
Risk Level: Low
Testing: unit tests, integration tests with full stack
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A