Proxy Protocol: Pass through V2 TLVs to upstream #24944

botengyao · 2023-01-13T18:40:31Z

Signed-off-by: Boteng Yao boteng@google.com
Co-authored-by: Siyuan Zhou siyuan.zhou@mongodb.com

This PR will store Proxy Protocol V2 TLVs to filter state based on the API config. And upstream can send these TLVs in transport socket based on the pass through config as well.

Some discussion already happened here: #18940
And thanks @siyuan.zhou@mongodb.com for the initial work.

Commit Message:
Additional Description:
Risk Level: Low
Testing: unit & integration test
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Boteng Yao <boteng@google.com>

repokitteh-read-only · 2023-01-13T18:40:36Z

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #24944 was opened by botengyao.

see: more, trace.

Signed-off-by: Boteng Yao <boteng@google.com>

repokitteh-read-only · 2023-01-20T03:33:57Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @markdroth
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #24944 was synchronize by botengyao.

see: more, trace.

Signed-off-by: Boteng Yao <boteng@google.com>

botengyao · 2023-01-20T04:01:31Z

Pending release note.

botengyao · 2023-01-20T15:19:57Z

/retest

repokitteh-read-only · 2023-01-20T15:20:09Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #24944 (comment) was created by @botengyao.

see: more, trace.

Signed-off-by: Boteng Yao <boteng@google.com>

repokitteh-read-only · 2023-01-20T20:03:47Z

🙀 Error while processing event:

evaluation error
error: function _rk_error error: path contains forbidden characters:
 Traceback (most recent call last):
  bootstrap:143: in <toplevel>
  bootstrap:135: in _main
  bootstrap:62: in _call
  bootstrap:15: in _call1
  github.com/repokitteh/modules/assign.star:18: in _assign
  github:395: in issue_check_assignee
  github:131: in call
Error: function _rk_error error: path contains forbidden characters

🐱

Caused by: a #24944 (comment) was created by @botengyao.

see: more, trace.

repokitteh-read-only · 2023-01-20T20:06:06Z

neither of as, well,, thanks! can be assigned to this issue.

🐱

Caused by: a #24944 (comment) was created by @botengyao.

see: more, trace.

botengyao · 2023-01-20T20:07:09Z

/assign @yanavlasov
Thanks!

yanavlasov

/wait

source/extensions/common/proxy_protocol/proxy_protocol_header.cc

envoy/network/proxy_protocol.h

source/extensions/filters/listener/proxy_protocol/proxy_protocol.h

source/extensions/transport_sockets/proxy_protocol/proxy_protocol.h

test/extensions/transport_sockets/proxy_protocol/proxy_protocol_integration_test.cc

Signed-off-by: Boteng Yao <boteng@google.com>

botengyao · 2023-01-27T16:37:14Z

Hi @envoyproxy/api-shepherds, and @markdroth, can we get this API reviewed? Thanks!

yanavlasov · 2023-01-27T18:27:44Z

@botengyao looks like build failure is real: https://source.cloud.google.com/results/invocations/f7ace5fd-8582-499c-aa4d-36e93034a549/log

yanavlasov · 2023-01-27T18:27:49Z

/wait

Signed-off-by: Boteng Yao <boteng@google.com>

botengyao · 2023-01-31T15:57:43Z

Hi @yanavlasov, @markdroth, and @envoyproxy/api-shepherds, cc @alyssawilk, PTAL, thanks!

yanavlasov

LGTM

yanavlasov · 2023-02-02T15:28:55Z

test/extensions/transport_sockets/proxy_protocol/proxy_protocol_integration_test.cc

+  initialize();
+
+  IntegrationTcpClientPtr tcp_client = makeTcpConnection(lookupPort("listener_0"));
+  ;


nit: extra ;

markdroth · 2023-02-02T16:18:13Z

/lgtm api

suniltheta

Just 1 clarifying question

api/envoy/config/core/v3/proxy_protocol.proto

pass all TLVs to upstream

7d25aec

Signed-off-by: Boteng Yao <boteng@google.com>

add proxy protocol config and integration test

f7ccc2c

Signed-off-by: Boteng Yao <boteng@google.com>

repokitteh-read-only bot added the api label Jan 20, 2023

repokitteh-read-only bot assigned markdroth Jan 20, 2023

botengyao changed the title ~~[WIP] Pass TLVs to upstream~~ Pass through TLVs to upstream Jan 20, 2023

botengyao changed the title ~~Pass through TLVs to upstream~~ Pass through Proxy Protocol V2 TLVs to upstream Jan 20, 2023

fix doc

6317e61

Signed-off-by: Boteng Yao <boteng@google.com>

botengyao added 2 commits January 20, 2023 16:11

remove fmt for log

954cf18

Signed-off-by: Boteng Yao <boteng@google.com>

Merge remote-tracking branch 'upstream/main' into pass_tlv_to_upstream

83ddb66

Signed-off-by: Boteng Yao <boteng@google.com>

botengyao marked this pull request as ready for review January 20, 2023 19:59

botengyao requested review from ggreenway and alyssawilk as code owners January 20, 2023 19:59

repokitteh-read-only bot assigned yanavlasov Jan 20, 2023

botengyao changed the title ~~Pass through Proxy Protocol V2 TLVs to upstream~~ Proxy Protocol: Pass through V2 TLVs to upstream Jan 20, 2023

yanavlasov reviewed Jan 24, 2023

View reviewed changes

source/extensions/common/proxy_protocol/proxy_protocol_header.cc Outdated Show resolved Hide resolved

source/extensions/common/proxy_protocol/proxy_protocol_header.cc Outdated Show resolved Hide resolved

envoy/network/proxy_protocol.h Outdated Show resolved Hide resolved

repokitteh-read-only bot added the waiting label Jan 24, 2023

yanavlasov requested changes Jan 25, 2023

View reviewed changes

source/extensions/filters/listener/proxy_protocol/proxy_protocol.h Outdated Show resolved Hide resolved

yanavlasov requested changes Jan 25, 2023

View reviewed changes

source/extensions/transport_sockets/proxy_protocol/proxy_protocol.h Outdated Show resolved Hide resolved

yanavlasov requested changes Jan 25, 2023

View reviewed changes

test/extensions/transport_sockets/proxy_protocol/proxy_protocol_integration_test.cc Outdated Show resolved Hide resolved

test/extensions/transport_sockets/proxy_protocol/proxy_protocol_integration_test.cc Outdated Show resolved Hide resolved

address comments

f99463a

Signed-off-by: Boteng Yao <boteng@google.com>

repokitteh-read-only bot removed the waiting label Jan 25, 2023

clean up

6a417b5

Signed-off-by: Boteng Yao <boteng@google.com>

botengyao added 2 commits January 27, 2023 16:06

fix ci

0978164

Signed-off-by: Boteng Yao <boteng@google.com>

Merge remote-tracking branch 'upstream/main' into pass_tlv_to_upstream

6076c49

Signed-off-by: Boteng Yao <boteng@google.com>

repokitteh-read-only bot added the waiting label Jan 27, 2023

fix build

c692d22

Signed-off-by: Boteng Yao <boteng@google.com>

repokitteh-read-only bot removed the waiting label Jan 27, 2023

change comments

0214fa7

Signed-off-by: Boteng Yao <boteng@google.com>

botengyao requested review from yanavlasov and removed request for ggreenway and alyssawilk January 31, 2023 16:25

yanavlasov approved these changes Feb 2, 2023

View reviewed changes

repokitteh-read-only bot removed the api label Feb 2, 2023

yanavlasov merged commit 74508c8 into envoyproxy:main Feb 2, 2023

suniltheta reviewed Feb 2, 2023

View reviewed changes

api/envoy/config/core/v3/proxy_protocol.proto Show resolved Hide resolved

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Proxy Protocol: Pass through V2 TLVs to upstream #24944

Proxy Protocol: Pass through V2 TLVs to upstream #24944

botengyao commented Jan 13, 2023 •

edited

Loading

repokitteh-read-only bot commented Jan 13, 2023

repokitteh-read-only bot commented Jan 20, 2023

botengyao commented Jan 20, 2023

botengyao commented Jan 20, 2023

repokitteh-read-only bot commented Jan 20, 2023

repokitteh-read-only bot commented Jan 20, 2023

repokitteh-read-only bot commented Jan 20, 2023

botengyao commented Jan 20, 2023

yanavlasov left a comment

botengyao commented Jan 27, 2023

yanavlasov commented Jan 27, 2023

yanavlasov commented Jan 27, 2023

botengyao commented Jan 31, 2023 •

edited

Loading

yanavlasov left a comment

yanavlasov Feb 2, 2023

markdroth commented Feb 2, 2023

suniltheta left a comment

Proxy Protocol: Pass through V2 TLVs to upstream #24944

Proxy Protocol: Pass through V2 TLVs to upstream #24944

Conversation

botengyao commented Jan 13, 2023 • edited Loading

repokitteh-read-only bot commented Jan 13, 2023

repokitteh-read-only bot commented Jan 20, 2023

botengyao commented Jan 20, 2023

botengyao commented Jan 20, 2023

repokitteh-read-only bot commented Jan 20, 2023

repokitteh-read-only bot commented Jan 20, 2023

repokitteh-read-only bot commented Jan 20, 2023

botengyao commented Jan 20, 2023

yanavlasov left a comment

Choose a reason for hiding this comment

botengyao commented Jan 27, 2023

yanavlasov commented Jan 27, 2023

yanavlasov commented Jan 27, 2023

botengyao commented Jan 31, 2023 • edited Loading

yanavlasov left a comment

Choose a reason for hiding this comment

yanavlasov Feb 2, 2023

Choose a reason for hiding this comment

markdroth commented Feb 2, 2023

suniltheta left a comment

Choose a reason for hiding this comment

botengyao commented Jan 13, 2023 •

edited

Loading

botengyao commented Jan 31, 2023 •

edited

Loading