Separate TestRandomGenerator from utility_lib #25050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
|
/retest |
|
Retrying Azure Pipelines: |
|
Build failure seems legit /wait |
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
…y to include utility.h Signed-off-by: Raven Black <ravenblack@dropbox.com>
(Past Windows breakage rollback.) Signed-off-by: Raven Black <ravenblack@dropbox.com>
|
LGTM |
pradeepcrao
approved these changes
Jan 24, 2023
RyanTheOptimist
approved these changes
Jan 27, 2023
VishalDamgude
pushed a commit
to freshworks/envoy
that referenced
this pull request
Feb 2, 2023
Commit Message: Separate TestRandomGenerator from utility_lib Additional Description: This is a precursor cleanup to envoyproxy#24994. When adding stat() to Filesystem operations, the fake file system will need to keep track of file timestamps. As such, it needs access to a TimeSource to generate those timestamps, i.e. simulated_time_system.h. However, utility.h depends on the Memfile filesystem, and simulated_time_system depended on utility.h, so this creates a circular dependency. simulated_time_system only actually wants random numbers and thread_factory from utility.h, so separating TestRandomGenerator into its own library allows for a reduction in the dependency chain size and a solution to that otherwise-upcoming circular dependency. Risk Level: None, this is test-only and no-op. Testing: Test-only and no-op. Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Raven Black <ravenblack@dropbox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Separate TestRandomGenerator from utility_lib
Additional Description: This is a precursor cleanup to #24994. When adding stat() to Filesystem operations, the fake file system will need to keep track of file timestamps. As such, it needs access to a TimeSource to generate those timestamps, i.e.
simulated_time_system.h. However, utility.h depends on the Memfile filesystem, and simulated_time_system depended on utility.h, so this creates a circular dependency. simulated_time_system only actually wants random numbers and thread_factory from utility.h, so separating TestRandomGenerator into its own library allows for a reduction in the dependency chain size and a solution to that otherwise-upcoming circular dependency.Risk Level: None, this is test-only and no-op.
Testing: Test-only and no-op.
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a