deps: bump com_github_grpc_grpc -> 1.49.2
#25131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: river phillips <riverphillips1@gmail.com>
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
htuch
approved these changes
Jan 25, 2023
repokitteh-read-only
bot
removed
the
deps
|
/retest |
|
Retrying Azure Pipelines: |
htuch
previously approved these changes
Jan 27, 2023
|
@RiverPhillips the fail looks genuine: ERROR: /build/tmp/_bazel_envoybuild/b570b5ccd0454dc9af9f65ab1833764d/external/com_github_grpc_grpc/src/core/BUILD:75:16: in @bazel_compdb//:aspects.bzl%compilation_database_aspect aspect on cc_library rule @com_github_grpc_grpc//src/core:transport_fwd:
Traceback (most recent call last):
File "/build/tmp/_bazel_envoybuild/b570b5ccd0454dc9af9f65ab1833764d/external/bazel_compdb/aspects.bzl", line 312, column 48, in _compilation_database_aspect_impl
compile_commands = _cc_compile_commands(ctx, target, feature_configuration, cc_toolchain)
File "/build/tmp/_bazel_envoybuild/b570b5ccd0454dc9af9f65ab1833764d/external/bazel_compdb/aspects.bzl", line 157, column 73, in _cc_compile_commands
compiler_options = cc_common.get_memory_inefficient_command_line(
Error in get_memory_inefficient_command_line: Invalid toolchain configuration: Cannot find variable named 'module_name'. |
Signed-off-by: river phillips <riverphillips1@gmail.com>
|
Cheers @phlax, this errors seems to occur on versions >=1.50.0. I'll change this PR to bump it to |
auto-merge was automatically disabled
January 27, 2023 20:45
Head branch was pushed to by a user without write access
RiverPhillips
changed the title
com_github_grpc_grpc -> 1.51.1com_github_grpc_grpc -> 1.49.2
htuch
approved these changes
Jan 30, 2023
VishalDamgude
pushed a commit
to freshworks/envoy
that referenced
this pull request
Feb 2, 2023
Signed-off-by: river phillips <riverphillips1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: river phillips riverphillips1@gmail.com
Commit Message: deps: bump
com_github_grpc_grpc-> 1.49.2Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]
I