Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distribution: Fix binary stripping to reduce deb size #25145

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

phlax
Copy link
Member

@phlax phlax commented Jan 25, 2023

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Member Author

phlax commented Jan 25, 2023

cc @ME-ON1

@phlax
Copy link
Member Author

phlax commented Jan 25, 2023

Seems like bazel doesnt strip as much as it uses -g

-g
-S
-d
--strip-debug

    Remove debugging symbols only.

https://bazel.build/reference/be/c-cpp#cc_binary_implicit_outputs

@phlax phlax merged commit c496715 into envoyproxy:main Jan 30, 2023
VishalDamgude pushed a commit to freshworks/envoy that referenced this pull request Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants