Change mobile binary size comparison workflow to use release build #25189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlax
changed the title
|
|
Signed-off-by: caschoener <schoener@google.com>
jpsim
approved these changes
Jan 27, 2023
This isn't terribly surprising. On iOS, where we statically link and deadstrip some code at link time, we see a ~5MB size increase from using Envoy Mobile to the compressed single-architecture iOS app. |
|
|
|
/retest |
|
Retrying Azure Pipelines: |
|
/retest |
|
Retrying Azure Pipelines: |
VishalDamgude
pushed a commit
to freshworks/envoy
that referenced
this pull request
Feb 2, 2023
…nvoyproxy#25189) Signed-off-by: caschoener <schoener@google.com>
jpsim
added a commit
that referenced
this pull request
Feb 7, 2023
This was accidentally disabled in #25189. Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was debugging a binary size increase in https://github.com/envoyproxy/envoy/actions/runs/4008291380/workflow and noticed that the comparison is based on --config=remote-ci-linux-clang. Talked with JP and it seems more appropriate to compare a release build instead.
Test plan: Look at CI