Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: Update docs dependencies #25257

Merged
merged 1 commit into from
Feb 3, 2023
Merged

deps: Update docs dependencies #25257

merged 1 commit into from
Feb 3, 2023

Conversation

phlax
Copy link
Member

@phlax phlax commented Jan 31, 2023 •
edited
Loading

this PR:

  • updates main docs deps
    • sphinx
    • sphinx extensions
    • docutils
    • related envoy deps
  • updates custom js search jquery -> js

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax marked this pull request as draft January 31, 2023 14:36
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Jan 31, 2023
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @moderation

🐱

Caused by: #25257 was opened by phlax.

see: more, trace.

@phlax phlax changed the title deps: Update docs dependencies [WIP] deps: Update docs dependencies Jan 31, 2023
@phlax
Copy link
Member Author

phlax commented Jan 31, 2023

/docs

@repokitteh-read-only
Copy link

Docs for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/25257/docs/index.html

The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.

🐱

Caused by: a #25257 (comment) was created by @phlax.

see: more, trace.

@phlax
Copy link
Member Author

phlax commented Jan 31, 2023 •
edited
Loading

i have had to fork vendor 2 of the sphinx-related deps (in the upstream pytooling dep) to unpin them <> docutils

sphinx_rtd_theme is vendored which is quite helpful as one of the reasons for doing these updates is to work on the theme. The rtd theme provides great examples for js assets, localisation, etc

the other is sphinx_tabs which i will remove as soon as executablebooks/sphinx-tabs#171 is resolved

@phlax phlax force-pushed the deps-bump-docutils branch from 9324d46 to e0e1033 Compare January 31, 2023 21:16
@phlax
Copy link
Member Author

phlax commented Jan 31, 2023 •
edited
Loading 

downloadable font: download failed (font-family: "Roboto Slab" style:normal weight:700 stretch:100 src index:1): status=2147746065 source: https://storage.googleapis.com/envoy-pr/92584f9/docs/_static/css/fonts/Roboto-Slab-Bold.woff?bed5564a116b05148e3b3bea6fb1162a

missing icons fixed

@phlax phlax mentioned this pull request Feb 1, 2023
Merged
nryant added a commit to nryant/ldc-bpcsad that referenced this pull request Feb 1, 2023
@nryant
build: pin versions of packages required to build docs; avoid depende…
9c261f2 
…ncy hell

sphinx-tabs (https://github.com/executablebooks/sphinx-tabs) currently pins docutils 0.18.0, which results in dependency hell unless Sphinx, sphinx extensions, sphinx_rtd_theme, etc are all pinned. May be resolved soon by:

    envoyproxy/envoy#25257
@phlax phlax force-pushed the deps-bump-docutils branch 2 times, most recently from be9ade1 to 5824ea2 Compare February 1, 2023 11:23
@phlax
deps: Update docs dependencies
451d30a 
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax force-pushed the deps-bump-docutils branch from 5824ea2 to 451d30a Compare February 1, 2023 14:49
@phlax phlax marked this pull request as ready for review February 1, 2023 14:49
@phlax phlax changed the title [WIP] deps: Update docs dependencies deps: Update docs dependencies Feb 1, 2023
@phlax phlax mentioned this pull request Feb 1, 2023
Closed
@phlax
Copy link
Member Author

phlax commented Feb 1, 2023

this has to land at the ~same time as envoyproxy/envoy-website#290

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Feb 3, 2023
@phlax phlax merged commit e6c17cf into envoyproxy:main Feb 3, 2023
phlax added a commit to phlax/envoy that referenced this pull request Feb 3, 2023
@phlax
deps: Update docs dependencies (envoyproxy#25257)
ef6dd4d 
Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
phlax added a commit to phlax/envoy that referenced this pull request Feb 4, 2023
@phlax
deps: Update docs dependencies (envoyproxy#25257)
1c0db2a 
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax added a commit to phlax/envoy that referenced this pull request Feb 4, 2023
@phlax
deps: Update docs dependencies (envoyproxy#25257)
56adf72 
Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
phlax added a commit that referenced this pull request Feb 6, 2023
@phlax
deps: Update docs dependencies (#25257)
3b20732 
Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
phlax added a commit that referenced this pull request Feb 6, 2023
@phlax
deps: Update docs dependencies (#25257)
e1b8422 
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax added a commit that referenced this pull request Feb 6, 2023
@phlax
deps: Update docs dependencies (#25257)
f61ab51 
Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanTheOptimist RyanTheOptimist RyanTheOptimist approved these changes

Assignees

@moderation moderation

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phlax @RyanTheOptimist @moderation