Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Only run mobile jobs in the Envoy repo #25361

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

phlax
Copy link
Member

@phlax phlax commented Feb 5, 2023

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Member Author

phlax commented Feb 5, 2023

cc @jpsim this is fairly urgent as mirror repos are trying to run all of the mobile tests and failing

the solution is far from ideal - having to exclude at the job level - after trawling through the docs and design decisions here i have come to the firm conclusion that github/ms' intention is to trigger as much unwanted CI as they can get away with

Copy link
Contributor

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to unblock, however we should consider doing the same for the other GitHub Actions CI jobs like CodeQL.

Also, do we have something similar in place for the Azure Pipelines CI?

@phlax
Copy link
Member Author

phlax commented Feb 6, 2023

i think we do this already for ~all of the existing gh jobs - in the case of azp we want them to run in current mirror

@phlax
Copy link
Member Author

phlax commented Feb 6, 2023

... in the case of azp we want them to run in current mirror

so actually this is slightly more complex - azp has to be setup for a repo for it to trigger at all - so i think the file is harmless if that is not set up, and ~needed if it is

fwiw, triggers in the file are mostly ignored in favour of web config even where it is set up

@phlax phlax merged commit d0c689d into envoyproxy:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants