Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: add CI jobs to build Envoy Mobile with custom compile time flags #25387

Merged
merged 1 commit into from
Feb 6, 2023
Merged

mobile: add CI jobs to build Envoy Mobile with custom compile time flags #25387

merged 1 commit into from
Feb 6, 2023

Conversation

jpsim
Copy link
Contributor

@jpsim jpsim commented Feb 6, 2023

These will give us some level of additional coverage to ensure that builds don't break with custom compile time options.

For stronger coverage we'd also run the tests but I'm concerned about the additional CI load for that, so prefer starting with just builds.

Commit Message:
Additional Description:
Risk Level:
Testing: CI :)
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
Fixes: #25379
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

These will give us some level of additional coverage to ensure that
builds don't break with custom compile time options.

For stronger coverage we'd also run the tests but I'm concerned about
the additional CI load for that, so prefer starting with just builds.

Signed-off-by: JP Simard <jp@jpsim.com>
@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #25387 was opened by jpsim.

see: more, trace.

@jpsim jpsim marked this pull request as ready for review February 6, 2023 18:59
@jpsim jpsim enabled auto-merge (squash) February 6, 2023 19:06
@jpsim
Copy link
Contributor Author

jpsim commented Feb 6, 2023

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #25387 (comment) was created by @jpsim.

see: more, trace.

@jpsim
Copy link
Contributor Author

jpsim commented Feb 6, 2023

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #25387 (comment) was created by @jpsim.

see: more, trace.

@jpsim jpsim merged commit d9282c6 into envoyproxy:main Feb 6, 2023
@jpsim jpsim deleted the mobile-add-ci-jobs-to-build-envoy-mobile-with-custom-compile-time-flags branch February 6, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mobile: add a CI job to compile Envoy Mobile with some features disabled
2 participants