Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiche roll 20230206164719 #25394

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

alyssawilk
Copy link
Contributor

@alyssawilk alyssawilk commented Feb 6, 2023

Risk Level: low
Testing: updated tests
Docs Changes: n/a
Release Notes: n/a

https://github.com/google/quiche/compare/bebdfcd7e..b901e844b

```
$ git log bebdfcd7e..b901e844b --date=short --no-merges --format="%ad %al %s"

2023-02-03 martinduke Internal change
2023-02-03 martinduke Remove redundant code to report ECN marks.
2023-02-02 quiche-dev Fix Windows build error due to implicit cast of uint64_t to WebTransportStreamError which is uint8_t.
2023-02-02 vasilvv Fix QUICHE bazel build by adding a missing dependency
2023-02-02 danzh Internal change
2023-02-01 vasilvv Simplify capsule.h to reduce the amount of code per individual capsule.
```

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #25394 was opened by alyssawilk.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Feb 6, 2023
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @mattklein123

🐱

Caused by: #25394 was opened by alyssawilk.

see: more, trace.

Copy link
Contributor

@RyanTheOptimist RyanTheOptimist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming it passes CI.

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Feb 6, 2023
@martinduke
Copy link
Contributor

I presume you need to change the Decrypters too.

@alyssawilk alyssawilk marked this pull request as ready for review February 7, 2023 14:02
@alyssawilk alyssawilk merged commit e7dbda0 into envoyproxy:main Feb 7, 2023
@alyssawilk
Copy link
Contributor Author

interestingly (to me) Null Decrypters weren't used (according to both grep and CI) :-P

@alyssawilk alyssawilk deleted the quiche-roll-20230206164719 branch March 19, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants