UHV: Enable oghttp2 and UHV in HTTP/2 flood test #27543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yan Avlasov <yavlasov@google.com>
yanavlasov
changed the title
KBaichoo
reviewed
May 25, 2023
|
/wait |
KBaichoo
approved these changes
Jun 7, 2023
asheryerm
pushed a commit
to asheryerm/envoy
that referenced
this pull request
Jul 5, 2023
Enable oghttp2 and UHV in HTTP/2 flood test Signed-off-by: Yan Avlasov <yavlasov@google.com> Signed-off-by: asheryer <asheryer@amazon.com>
reskin89
pushed a commit
to reskin89/envoy
that referenced
this pull request
Jul 11, 2023
Enable oghttp2 and UHV in HTTP/2 flood test Signed-off-by: Yan Avlasov <yavlasov@google.com> Signed-off-by: Ryan Eskin <ryan.eskin89@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Description:
HTTP/2 flood test was using decommissioned
envoy.reloadable_features.http2_new_codec_wrapperflag (which is no-op) and was not using oghttp2 or UHV. This change enables testing of oghttp2 with and without UHV by the flood test.Also removed duplicated increment of the
upstream_cx_protocol_errorflag in UHV mode which triggered errors in the flood test.Risk Level: Low, build flag protected
Testing: Unit Tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A