logger: removed NVLOG compile flag #2886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added convenience macros to check logger's current severity level before entering iterative logging. Added Unit test for new macro ENVOY_LOG_CHECK_LEVEL. Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
mattklein123
approved these changes
Mar 23, 2018
There was a problem hiding this comment.
This is a fantastic cleanup. Thank you. If possible can you add a release note here: https://github.com/envoyproxy/data-plane-api/blob/master/docs/root/intro/version_history.rst?
|
Release note added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: logger's trace and debug statements were compiled out when NVLOG flag was defined. This was done for performance reasons. #2751 introduced run-time logger's level check before invoking logging routines, but still compiled out trace and debug logging statements. This change, as per #2854, uses run-time logger's level checks for all levels, including trace and debug. NVLOG flag is not used in the code any more.
Risk Level: Low.
Testing: Added unit test to test new macro comparing logging levels.
Docs Changes: Yes - all logger levels can be configured in run-time now: trace, debug, info, warn, error and critical.
Release Notes: Yes - trace and debug log levels are used in all releases.