server: Move a few internal APIs from std::string to absl::string_view. #2889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Marantz <jmarantz@google.com>
|
@ggreenway can you take a first pass at this? |
Signed-off-by: Joshua Marantz <jmarantz@google.com>
ggreenway
reviewed
Mar 23, 2018
source/server/http/admin.cc
Outdated
| Buffer::Instance& response) { | ||
| Http::Utility::QueryParams query_params = Http::Utility::parseQueryString(url); | ||
| Http::Utility::QueryParams query_params = Http::Utility::parseQueryString(std::string(url)); |
There was a problem hiding this comment.
You can avoid this conversion/allocation if you push one level deeper into this function. I think it would be straightforward without affecting other functions, at least at first glance. But up to you if you want to do that or not.
There was a problem hiding this comment.
Yeah I didn't need that construction. Good catch.
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joshua Marantz jmarantz@google.com
Description: Changes a few internal interfaces from std::string to absl::string_view, reducing the number of temporary allocations and memcpys that must be made.
Risk Level: Low
Testing: //test/..., tsan, asan, msan (sanitizers in progress)
Release Notes: N/A