config: optimize RepeatedPtrUtil::debugString at non-debug log levels. #2984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one was showing up on our flamegraphs. Risk Level: Low Testing: bazel build //source/exe/... Signed-off-by: Harvey Tuch <htuch@google.com>
mattklein123
approved these changes
Apr 3, 2018
htuch
added a commit
to htuch/envoy
that referenced
this pull request
Apr 11, 2018
…g levels. (envoyproxy#2984)" This reverts commit 4874315. As pointed out by @alyssawilk, this doesn't make sense given envoyproxy#2751. I think the profile that motivated this must have been created before the Google import included envoyproxy#2751. Signed-off-by: Harvey Tuch <htuch@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one was showing up on our flamegraphs.
Risk Level: Low
Testing: bazel build //source/exe/...
Signed-off-by: Harvey Tuch htuch@google.com